slackhq / slackhq/vscode-hack

Bad syntax highlighting of XHP class definitions

Open
#117 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

syntax
Dominant language
TypeScript
Stars
80
Forks
47
PR merge metrics
No merged PRs in 30d

Description

class Foo {}

class bar {}

class :biz {}

Screenshot 2021-05-12 at 16 12 56

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the three class-definition examples from the issue in the VS Code Hack extension and compare the highlighting with the attached screenshot. Find the extension's syntax-highlighting implementation, then verify that ordinary classes, lowercase class names, and XHP classes are highlighted correctly.

Written by the indexing model from the issue text.

Assessment

Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.