slackapi / slackapi/python-slack-sdk

Why are deprecated methods not commented out or removed?

Open
#1,531 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Version: 3x web-client
Dominant language
Python
Stars
4k
Forks
857
Avg merge
22h 21m
Merged PRs (30d)
16

Description

Is there a reason that deprecated methods, such as groups_createChild, are allowed to be called? As the deprecation happened 3.5 years ago, it feels like it's a good time to comment them out or remove it. An old issue had a similar question, but it's not quite the same question.

https://github.com/slackapi/python-slack-sdk/blob/417fc5b269dba776b0ddb60223a756130815292d/slack_sdk/web/client.py#L3840-L3848

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in slack_sdk/web/client.py around lines 3840-3848 and review the related discussion in issue #1395. Identify the project’s deprecation policy and the scope of deprecated methods before determining whether removal or commenting out is appropriate. Done means a maintainer-approved decision with the affected methods and compatibility impact documented.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.