slackapi / slackapi/node-slack-sdk

`message_replied` event missing text property in typescript

Open
#2,025 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area:typescript bug pkg:types semver:major
Dominant language
TypeScript
Stars
3.4k
Forks
688
Avg merge
15h 31m
Merged PRs (30d)
27

Description

Description

The text property does not exist on MessageRepliedEvent interface in typescript

What type of issue is this? (place an x in one of the [ ])
  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • example code related
  • testing related
  • discussion
Requirements (place an x in each of the [ ])
  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

Bug Report

Filling out the following details about bugs will help us solve your issue sooner.

Reproducible in:

package version: 3.12.1

node version: 16.3.2

OS version(s): MacOS 12.4

Steps to reproduce:
slackApp.message(subtype("message_replied"), async ({ message }) => {
  if (message.subtype === "message_replied") {
    const messageThreadId = message.message.thread_ts;

    // Find the socket for the given thread ID
    for (const connection in openConnections) {
      const connectionProps = openConnections[connection];
      if (connectionProps.thread === messageThreadId) {
        connectionProps.socket.send(message.message.text); <---
      }
    }
  }
})
Expected result:

message.message.text is type string per event documentation:

https://api.slack.com/events/message/message_replied

Actual result:
Property 'text' does not exist on type 'MessageEvent & { thread_ts: string; reply_count: number; replies: MessageEvent[]; }'.
  Property 'text' does not exist on type 'MessageChangedEvent & { thread_ts: string; reply_count: number; replies: MessageEvent[]; }'
Attachments:

Screen Shot 2022-09-01 at 5 27 23 PM

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the TypeScript definition for the MessageRepliedEvent interface and trace the message_replied handler type used by the example. Confirm the event documentation's text property is represented, then verify that message.message.text type-checks without the reported error.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.