slackapi / slackapi/java-slack-sdk
5 threads (for the default singleton) can be created even when SlackConfig#statsEnabled is false
Open
@seratch is already working on this.
Since May 19, 2022.
enhancement
project:slack-api-client
- Dominant language
- Java
- Stars
- 602
- Forks
- 232
- Avg merge
- 4d 9h
- Merged PRs (30d)
- 7
Description
Developers can disable API clients' metrics management by setting SlackConfig#statsEnabled to false. Even in this case, the default SlackConfig object creation (as a static field in the class) starts 5 threads and those threads are unused. See the repro steps below for details.
Reproducible in:
any versions
The Slack SDK version
any versions
Java Runtime version
any versions
OS info
any versions
Steps to reproduce:
Running the following code and checking the thread dump.
SlackConfig config = new SlackConfig();
config.setStatsEnabled(false);
Slack slack = Slack.getInstance(config);
Expected result:
No threads under a "slack-api-metrics" thread group are created.
Actual result:
5 threads for the default singleton SlackConfig instance are created.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.