slackapi / slackapi/java-slack-sdk
Upgrade Tyrus WebSocket client library (used in Socket Mode client ) to v2
Open
Nobody has claimed this yet.
dependencies
enhancement
project:slack-api-client
- Dominant language
- Java
- Stars
- 602
- Forks
- 232
- Avg merge
- 4d 9h
- Merged PRs (30d)
- 7
Description
(Describe your issue and goal here)
Reproducible in:
mvn dependency:tree | grep com.slack.api
gradle dependencies | grep com.slack.api
java -version
sw_vers && uname -v # or `ver`
The Slack SDK version
implementation 'com.slack.api:bolt-socket-mode:1.21.1'
implementation "javax.websocket:javax.websocket-api:1.1"
implementation "org.glassfish.tyrus.bundles:tyrus-standalone-client:1.17"
Java Runtime version
openjdk version "17.0.1" 2021-10-19 LTS
OpenJDK Runtime Environment Zulu17.30+15-CA (build 17.0.1+12-LTS)
OpenJDK 64-Bit Server VM Zulu17.30+15-CA (build 17.0.1+12-LTS, mixed mode, sharing)
OS info
ProductName: macOS
ProductVersion: 12.3.1
BuildVersion: 21E258
Darwin Kernel Version 21.4.0: Fri Mar 18 00:46:32 PDT 2022; root:xnu-8020.101.4~15/RELEASE_ARM64_T6000
Steps to reproduce:
AppConfig appConfig = AppConfig.builder().singleTeamBotToken(mainApp.botOauthToken).build();
appConfig.getSlack().getConfig().setProxyUrl("http://localhost:7890/");
mainApp.app = new App(appConfig);
SocketModeApp socketModeApp = new SocketModeApp(mainApp.appToken, SocketModeClient.Backend.Tyrus, mainApp.app);
Expected result:
can we support socks5 proxy for both slack http api and websocket api
Actual result:
Apr 17, 2022 10:06:30 PM org.glassfish.tyrus.container.grizzly.client.GrizzlyClientSocket addProxies
INFO: Socks proxy is not supported, please file new issue at https://java.net/jira/browse/TYRUS. Proxy 'SOCKS @ 127.0.0.1/<unresolved>:7890' will be ignored.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the bolt-socket-mode, javax.websocket-api, and tyrus-standalone-client dependency declarations, then inspect SocketModeApp construction with SocketModeClient.Backend.Tyrus and the proxy configuration. Verify how the Tyrus backend handles SOCKS5 proxies for the Slack HTTP and WebSocket clients; done means the proxy is supported without the reported warning.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- api, backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100