slackapi / slackapi/java-slack-sdk

MethodsCompletionException is unnecessarily complex

Open
#1,452 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement project:slack-api-client
Dominant language
Java
Stars
602
Forks
232
Avg merge
4d 9h
Merged PRs (30d)
7

Description

The com.slack.api.methods.MethodsCompletionException does not align with the partner's API (getMessage) and is challenging to maintain. It requires handling specific exceptions and examining complex details to retrieve information.
However, the implementation is unnecessarily complex and could be significantly simplified.

The Slack SDK version

1.45.3

Expected result:

It is easy to use Slack exceptions because they follow the default behavior and implement the default methods

Actual result:

Exception handling requires some specialized code

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with slack-api-client/src/main/java/com/slack/api/methods/MethodsCompletionException.java and compare its exception handling with the partner API's getMessage behavior. Simplify the implementation so Slack exceptions follow default exception behavior and methods, then verify that specialized handling is no longer required.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.