slackapi / slackapi/bolt-js

Use `unknown` instead of `any` for `StringIndexed`

Open
#1,661 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

discussion semver:major TypeScript-specific
Dominant language
TypeScript
Stars
2.9k
Forks
445
Avg merge
1d 3h
Merged PRs (30d)
28

Description

https://github.com/slackapi/bolt-js/blob/e14c6a19f9435607745daf16aab4062cf6b731a7/src/types/helpers.ts#L5

As per title, I think it should be unknown to prevent accessing properties which may not exist.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading src/types/helpers.ts at line 5, the location linked in the issue, and inspect how StringIndexed is used. Update the type as requested and confirm the existing TypeScript checks still pass without allowing unsupported property access.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
developer-experience
Issue type
Refactor
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.