slack-ruby / slack-ruby/slack-ruby-client
Consider using keyword arguments and require Ruby 2.1
Open
Nobody has claimed this yet.
new feature
question
- Dominant language
- Ruby
- Stars
- 1.3k
- Forks
- 222
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 3
Description
Ruby 2.1 has required keyword arguments, that could clean up a lot manual checking for existence of a key in options.
Would you consider requiring Ruby 2.1 ? I'd say it is not so strict requirement, given Rails 5 will require Ruby 2.2.
See 9174022 how it looks.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or tests are named. Start by reviewing commit 9174022 and locating the manual options-key checks across the client; determine the Ruby version support policy and the scope of any keyword-argument changes. Done means the compatibility decision is implemented consistently and the existing test suite still passes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- backend-api-design
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100