skyzh / skyzh/tiny-llm

precision issues in M1

Open
#45 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
4.6k
Forks
383
Avg merge
5h 40m
Merged PRs (30d)
34

Description

during my own testing and people's feedbacks it seems that some kernels on M1 has precision issues in RoPE. Likely due to sin/cos.

https://github.com/skyzh/tiny-llm/issues/27

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named; begin by reading linked issue #27 and reproducing the reported precision problem on M1. Trace the affected RoPE sin/cos calculations and identify which kernel or kernels are involved. Done means the affected precision behavior is corrected and the reproduction check passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
machine-learning
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.