skydoves / skydoves/compose-effects
[Feature request] Avoid creating an instance RememberedEffectImpl
Open
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 152
- Forks
- 6
- PR merge metrics
- No merged PRs in 30d
Description
Is your feature request related to a problem?
Could the instance of RememberedEffectImpl just be avoided?
Describe the solution you'd like:
@Composable
@NonRestartableComposable
fun RememberedEffect(
key1: Any?,
effect: () -> Unit
) {
//noinspection RememberReturnType
remember(key1) {
effect()
}
}
Describe alternatives you've considered:
N/A
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the declaration and implementation of RememberedEffect and RememberedEffectImpl in the project, then inspect how the composable is used. Verify that the implementation no longer creates a RememberedEffectImpl instance while retaining the requested remember-based effect behavior; the issue does not name a test to run.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- mobile
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100