sktime / sktime/pytorch-forecasting

Demand forecasting example and usage of TimeSeriesDataSet for Validation and Testing

Open
#641 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
5k
Forks
912
Avg merge
3d 13h
Merged PRs (30d)
12

Description

  • PyTorch-Forecasting version: 0.9.0
  • PyTorch version: 1.9.0
  • Python version: 3.7
  • Operating System: Windows and Linux

Hello,

thanks for the amazing package, I really enjoy your work.

I had a small question regarding the TimeSeriesDataSet and it's relation with training, validation and testing data. For my elaboration, I primarily focus on your example of the Demand forecasting.

If I see it correctly, you are defining for each of the three datasets an individual TimeSeriesDataSet, thus also create a Normalizer for each dataset seperately. However, if I am not mistaken, this would include future information in the normalization process, which is highly problematic in the time series context. On the other hand, I also saw that you designed a specific function for this problem, i.e. the TimeSeriesDataSet.from_dataset().

Therefore my question, if you could elaborate, why you chose the seperate creation of the TimeSeriesDataSet instead of transfering the training Normalizers ?

Thanks in advance

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Demand forecasting example and the TimeSeriesDataSet.from_dataset() entry point, then compare how the training, validation, and testing datasets create and reuse normalizers. Done means documenting whether separate dataset construction leaks future information and when the training normalizers should be transferred.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
machine-learning
Issue type
Documentation
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.