assemble-samples.sh: clearer diagnostics on mismatch
Open
Beginner friendly
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 0
- Forks
- 0
- Avg merge
- 1d 7h
- Merged PRs (30d)
- 2
Description
Two small diagnostics improvements to scripts/ci/assemble-samples.sh:
- When the final count check fails (
want [11], got [N]), the message does not say which PDFs are unexpected or missing. On mismatch, list the directory contents to stderr so the failing run is self-explanatory. - A comment (and its introducing commit message) describes the pre-check as replacing "shell wording" — what it actually replaces is
cp's own diagnostics. Fix the comment wording.
Both are cosmetic; the checks themselves behave correctly (verified against the four failure cases: empty generated dir, one missing sample, full set, stale extra file).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with scripts/ci/assemble-samples.sh and inspect the final count check, pre-check, and nearby comments. Re-run the four stated failure cases; done means mismatch output identifies the directory contents on stderr and the comment accurately refers to cp diagnostics, while the checks still pass for the full set.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- shell
- Domain
- ci-cd
- Issue type
- Refactor
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 88/100