skiptools / skiptools/skip-ui

Sheet dismisses on rotation

Open
#59 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Swift
Stars
330
Forks
76
Avg merge
3h 6m
Merged PRs (30d)
1

Description

User report:

Having a weird issue where when presenting a sheet on android and changing the devices orientation the sheet is dismissed. Seems to only happen with:
.sheet(item: $selectedItem) { item in
While this way isn't dismissed:
.sheet(isPresented: $isPresenting) {

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue on Android with .sheet(item:) while changing orientation, then compare it with the working .sheet(isPresented:) case. Done means the item-based sheet remains presented after rotation, with the existing behavior verified for both presentation forms.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, swift
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.