skiptools / skiptools/skip-ui

NavigationLink renders Label with a different format and icon side in Menu

Open
#485 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Swift
Stars
330
Forks
76
Avg merge
3h 6m
Merged PRs (30d)
1

Description

NavigationLink renders Label differently from Button and ShareLink in a Menu.

If you add a Menu to a toolbar a NavigationLink's label will be rendered differently, the icon will be on the left instead of right, and the text formatting will be a different font size, weight and padding.

Image
.toolbar {
    Menu {
        Button("Title", systemImage: "symbolName") {
            ...
        }
        ShareLink(item: value) {
            Label("Title", systemImage: "symbolName")
        }
        NavigationLink {
            Text("Another view")
        } label: {
            Label("Title", systemImage: "symbolName")
        }
    } label: {
        ...
    }

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the provided toolbar Menu reproduction and compare the Button, ShareLink, and NavigationLink entries, focusing on Label formatting, icon placement, font, weight, and padding. Trace the NavigationLink rendering entry point and verify that its Menu appearance matches the other actions without changing their behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.