`ToolbarItem` `Button` should render as M3 `TextButton` or `IconButton`
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Swift
- Stars
- 330
- Forks
- 76
- Avg merge
- 3h 6m
- Merged PRs (30d)
- 1
Description
Today, ToolbarItem Button renders in buttonStyle(.default), i.e. we just make them clickable. This means that for text-only buttons, their ripple rectangle is tightly wrapped around their text.
It would be great if these could be TextButtons instead.
Here it is as a TextButton
When you tap down and hold, it has a nice ripple background:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the ToolbarItem Button rendering and the existing Material 3 button implementations. Check how text-only and icon-only toolbar buttons are represented, then verify that each uses the appropriate TextButton or IconButton styling and shows the expected ripple area when pressed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- design, mobile-dev
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100