skiptools / skiptools/skip-ui

Add support for multiple `.presentationDetents([.medium, .large])`

Open
#391 0 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Swift
Stars
330
Forks
76
Avg merge
3h 6m
Merged PRs (30d)
1

Description

In #37, we added support for presentationDetents(_:), but only 0 or 1 detent.

It should support multiple detents, like .presentationDetents([.medium, .large]).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the existing presentationDetents(_:) support added in issue #37 and trace how it handles zero or one detent. Extend the behavior for the [.medium, .large] example, then verify that multiple detents are accepted and presented correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
mobile
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.