skiptools / skiptools/skip-ui

System symbol Android fallbacks are frequently using the wrong fallback symbols

Open
#200 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

documentation
Dominant language
Swift
Stars
330
Forks
76
Avg merge
3h 6m
Merged PRs (30d)
1

Description

It's a lot of work to file bugs like #197 #198 and #199, so I'm just going to summarize additional mismatches here.

I think we should delete these fallbacks:

  • exclamationmark.triangle is empty/outlined, but Icons.Outlined.Warning is filled (despite the name "Outlined"). There's no good replacement that I can find.
  • face.smiling is smiling, but Icons.Outlined.Face has no mouth (and looks kinda nervous). There's no good replacement that I can find.
  • location/location.fill looks like an arrow; Icons.Outlined.LocationOn looks like a map pin. There's no good replacement that I can find.

I think we should replace this SF Symbol:

  • mappin.circle has a circle in it; Icons.Outlined.Place comes to a point. Make the fallback for mappin instead.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Android system-symbol fallback mapping for exclamationmark.triangle, face.smiling, location, location.fill, mappin.circle, and mappin. Compare the current mappings with the requested removals and replacement, then verify that the listed symbols no longer use the wrong fallbacks.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, swift
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.