skiptools / skiptools/skip-notify
Remove dependency on Firebase Messaging
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 6
- Forks
- 2
- Avg merge
- 3h 31m
- Merged PRs (30d)
- 2
Description
Currently, we depend on Firebase Messaging for handling push notifications: https://github.com/skiptools/skip-notify/blob/3ad44e165defe435cf6d618d9fe985d76ea40e02/Sources/SkipNotify/Skip/skip.yml#L24C28-L24C66
- 'implementation("com.google.firebase:firebase-messaging")'
But this dependency could be removed if we instead interface directly with the "com.google.android.gms" service on the device (if present), like was done at https://github.com/christianrowlands/ninja-chat/commit/1abb22b542343642aacb4f7bd82f0bb2bc380ea4
This opens the possibility of supporting devices that do not have Google Mobile Services available (AOSP builds, Chinese ROMs and other non-Android Certified devices, etc.), as well as enabling flexible support for multiple notification services (as discussed in https://github.com/skiptools/skip-notify/issues/2).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting Sources/SkipNotify/Skip/skip.yml at the cited dependency line and reading the referenced ninja-chat commit. Trace how push notifications are currently wired and identify the device service boundary described in the issue. Done means Firebase Messaging is no longer required while push support remains functional and the design can accommodate non-GMS services.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, firebase, swift
- Domain
- mobile-dev
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100