skiptools / skiptools/skip-bridge

Overridden constructor does not generate correct override bridge

Open
#86 1 comment 0 reactions 1 assignee View on GitHub

@aabewhite is already working on this.

Since Jun 1, 2025.

Dominant language
Swift
Stars
6
Forks
7
PR merge metrics
No merged PRs in 30d

Description

Given:

public class AVPlayer {
    public init(playerItem: AVPlayerItem?) {
        …
    }
}

public class AVQueuePlayer: AVPlayer {
    public override init(playerItem: AVPlayerItem?) {
        …
    }
}

The generated bridge is:

public class AVPlayer: BridgedFromKotlin {
    public init(playerItem p_0: AVPlayerItem?) {
        …
    }
}

public class AVQueuePlayer: AVPlayer {
    public init(playerItem p_0: AVPlayerItem?) {
        …
    }
}

which gives the compile error:

overriding declaration requires an 'override' keyword

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.