skiptools / skiptools/skip-authentication-services

Add support for missing Custom Tab implementation

Open
#8 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Swift
Stars
2
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Apropos #4, PR #7 fixed the case where the user has an older version of Chrome, but didn't fix the case where there's no Custom Tab implementation at all (e.g. no Chrome installed).

For example, if you create an Android Emulator on API 28 using "Google ARM64-V8a Play ARM 64 v8a System Image", you'll get a phone with no Chrome and only a minimal "WebView Browser Tester" app that doesn't support custom tabs. (The system WebView is on Chromium 66, from 2018!)

The library doesn't currently work properly in that case, even with the fallback intent filters.

To repro: On an API 28 emulator without Chrome, install the Showcase app, view the Web Authentication Session playground, and Sign In. It will open the WebView Browser Tester.

Actual: If you sign in, it will take you back to the home screen of the app.
Expected: When you sign in, it should display the result URL on the Web Authentication Session playground

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce this in the Showcase app on an API 28 emulator created with the Google ARM64-V8a Play ARM 64 v8a System Image, then open the Web Authentication Session playground and sign in. Investigate the missing Custom Tab path and verify that, without Chrome, the sign-in flow displays the result URL on the playground instead of returning to the app's home screen.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, swift
Domain
authentication, mobile-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.