skalenetwork / skalenetwork/node-cli

Improve node update - add SGX checks

Open
#833 1 comment 0 reactions 1 assignee View on GitHub

@dmytrotkk is already working on this.

Since Mar 3, 2025.

enhancement
Dominant language
Python
Stars
21
Forks
7
Avg merge
2d 17h
Merged PRs (30d)
5

Description

We had situations when validators provided incorrect values in the .env and started the update procedure with wrong values.

The proposal is to improve the checks BEFORE performing the update procedure.
If checks are not passing, the update procedure should be canceled with the error message. Existing containers should continue working without interruptions. Checks structure should be modular and unified so we can easily add new checks in the future or disable some of the different node types.

Proposed initial checks:

  • Disk check (already exist, should be added to the unified checks procedure)
  • Manager and IMA aliases check (already exist, should be added to the unified checks procedure)
  • NEW SGX check - node-cli should get the list of ALL keynames on the node and request each key using the provided SGX URL (no additional libraries, just plain requests) - procedure should fail if some keys are not found.

Initially proposed by @olehnikolaiev , he can provide more details.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.