sitespeedio / sitespeedio/sitespeed.io

Issue with coach core when using alongside sitespeed

Open
#4,546 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
5k
Forks
624
Avg merge
4h 8m
Merged PRs (30d)
2

Description

Your question

So I have ubuntu 24 docker image and I am installing sitespeed in it. Few months ago the build were being built properly however when I tried today I faced below issue

tries to install @sitespeed.io/edgedriver which fails when I do a cloud build
To resolve this I did below change
RUN bash -c ". $NVM_DIR/nvm.sh && nvm use 20 && cd /tmp/coach-core && npm install --production --no-optional--loglevel verbose"
After this I faced below issue

mkdirp/terser missing because coach-core runs its prepare script (which requires devDependencies).
To resolve this I changed the command to below
RUN bash -c ". $NVM_DIR/nvm.sh && nvm use 20 && cd /tmp/coach-core && npm install --omit=optional --loglevel verbose"
Which revolves me back to edgedriver error. Any help with this as I had not faced this issue before. Were any changes made in package.json

I basically install replace actual coachcore with the forked coach core repo. But I was able to do this successfully few months ago. @soulgalore any advice on this?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Docker build commands in the issue and inspect coach-core's package.json, especially its optional dependencies and prepare script. Reproduce the build with npm install --production --no-optional and npm install --omit=optional, then identify why @sitespeed.io/edgedriver conflicts with the prepare dependencies. Done means the forked coach-core installs successfully alongside sitespeed without either reported failure.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, javascript, node.js, ubuntu
Domain
build-system, devops
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.