sitespeedio / sitespeedio/sitespeed.io

Pass multiple visualElements

Open
#4,458 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
JavaScript
Stars
5k
Forks
624
Avg merge
4h 8m
Merged PRs (30d)
2

Description

Have you read the documentation?
URL

https://imm-5257-form.com/

What are you trying to accomplish

Hello. I found an issue where only the latter passed value is accepted for flag --scriptInput.visualElements

Image

Sitespeed verison: 35.7.5-plus1

What browser did you use?

Chrome

How to reproduce

Nutshell:

  --plugins.remove="@sitespeed.io/plugin-gpsi" \
  --plugins.remove="@sitespeed.io/plugin-lighthouse" \

Full command:

docker run --rm \
  --name sitespeed_test \
  -v "$(pwd):/sitespeed.io" \
  sitespeedio/sitespeed.io:35.7.5-plus1 \
  https://imm-5257-form.com/ \
  --n 1 \
  --plugins.remove="@sitespeed.io/plugin-gpsi" \
  --plugins.remove="@sitespeed.io/plugin-lighthouse" \
  --plugins.list \
  --visualElements \
  --scriptInput.visualElements="CustomReadiness_1:.cta-button" \
  --scriptInput.visualElements="CustomReadiness_2:.header-logo__name" \
  --filmstrip.showAll \
  --browsertime.videoParams.filmstripFullSize=true
Log output
None

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Run the supplied Docker command with both --scriptInput.visualElements values and confirm that only the latter is accepted. Trace the CLI handling of repeated visualElements inputs; done means both CustomReadiness_1 and CustomReadiness_2 values are preserved and used.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, javascript
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.