sitespeedio / sitespeedio/sitespeed.io
Budget should fail if there's missing data
Open
Nobody has claimed this yet.
bug
- Dominant language
- JavaScript
- Stars
- 5k
- Forks
- 624
- Avg merge
- 4h 8m
- Merged PRs (30d)
- 2
Description
I've been running budgets on Android phone and if the phone is not connected it looks like this:
[2020-10-23 08:30:56] ERROR: Error: No Android phone was found
at Android._init (/Users/phedenskog/git/sitespeed.io/node_modules/browsertime/lib/android/index.js:45:15)
at process._tickCallback (internal/process/next_tick.js:68:7)
[2020-10-23 08:30:56] INFO: Budget: 0 working and 0 failing tests
I wonder if we can make the tests fail if we miss data? That should make sense so its easier to alert on failures.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce a budget run with an Android phone disconnected and inspect how the budget result handles the “No Android phone was found” error. Done means missing data causes the budget command to report failing tests instead of “0 working and 0 failing tests.”
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- cli, testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100