sitespeedio / sitespeedio/sitespeed.io

Coach is showing assets are missing a cache time but they are definitely present

Open
#2,992 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
5k
Forks
624
Avg merge
4h 8m
Merged PRs (30d)
2

Description

When I'm running the above command and checking the coach output, one of the recommendations it gives states "The page has 276 request(s) that are missing a cache time. Configure a cache time so the browser doesn't need to download them every time. It will save 1.7 MB the next access."

However when I check one of the specific assets (in this example https://www.sainsburys.co.uk/wcsstore7.46hf.15/SainsburysStorefrontAssetStore/css/main.min.css), I can see that it does have a valid Cache-Control response header (Cache-Control: max-age=3600, s-maxage=3600, no-cache="set-cookie").

I can also see that in the waterfall in the report produced by sitespeedio.

I have attached a zipped copy of the run. Please can you take a look and confirm whether this is an actual bug?

Thanks!

www.sainsburys.co.uk.zip

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the exact Docker command, sitespeed.io 12.10.0, and the supplied URL, then inspect the Coach output, waterfall, and attached run archive. Done means determining why an asset with the shown Cache-Control header is reported as missing a cache time and correcting the recommendation if it is a bug.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, javascript
Domain
performance
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.