sitespeedio / sitespeedio/sitespeed.io

Reports over multiple domains merge/muddle results

Open
#2,385 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
5k
Forks
624
Avg merge
4h 8m
Merged PRs (30d)
2

Description

Running on Ubuntu 18.04 on a Jenkins slave headlessly.

    -b chrome \
    -n 3 \
    --chrome.timeline true \
    --visualMetrics true \
    --visualElements true \
    --pageCompleteCheckInactivity \
    --influxdb.host <host> \
    --influxdb.database sitespeed \
    --influxdb.annotationScreenshot true \
    --s3.bucketname <bucket> \
    --s3.acl public-read \
    --s3.removeLocalResult \
    --firstParty "..regex here.." \
    --resultBaseURL <base_url> \
    https://www.google.com https://www.duckduckgo.com

image

If you have any differing domains in the URLs passed to sitespeed, the results in the HTML report are mixed. e.g. the domains list contains all domains for both google and duckduck.

Expectation? Tossing out some ideas.

  • Generate a report for each unique host passed to sitespeed
  • Could throw an error/warning if html reports are enabled and more than one domain was passed into the tool.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the provided Docker command using google.com and duckduckgo.com, then inspect the generated HTML report and its domain lists. Determine whether separate reports or a warning is the intended outcome. Done means results from different hosts are no longer mixed, or the multi-domain limitation is clearly reported.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
data-visualization
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.