sitespeedio / sitespeedio/sitespeed.io
S3 path doesn't work with annotations
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 5k
- Forks
- 624
- Avg merge
- 4h 8m
- Merged PRs (30d)
- 2
Description
As reported in #2329
When trying to implement the path option that exists in S3 and also sending annotations to Graphite the resultUrls is completely ignoring the path option giving me:
INFO: [sitespeedio] Find the result at https://storage.googleapis.com/bucketname/www.my-domain.com/2019-02-21-10-49-01
Instead of (setting path to my-sub-folder/test1):
INFO: [sitespeedio] Find the result at https://storage.googleapis.com/bucketname/my-sub-folder/test1
This gives wrong urls in the annotations.
I do not have the possibility to test the S3 storage plugin but to me it looks like the same problem exists there? I have also inspected the message in the Graphite plugin and cant find any info about the path in there and also the Graphite plugin looks like it is run before storing the results in S3?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Trace how the S3 storage plugin builds resultUrls and how the Graphite plugin receives its message, focusing on the path option and the order in which annotations and storage run. Confirm that a configured path appears in both the reported URL and Graphite annotations, including the case where results are stored in S3.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- cloud, observability
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100