sitespeedio / sitespeedio/geckodriver

Typo in the environment variable

Open
#5 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
3
Forks
1
PR merge metrics
No merged PRs in 30d

Description

The overwrite of geckodriver version will not work due to typo in install.js
GECKORIVER_VERSION

const GECKODRIVER_VERSION = process.env.GECKODRIVER_VERSION
  ? `v${process.env.GECKORIVER_VERSION}`
  : `v${pkg.geckodriver_version}`;

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open install.js and inspect the GECKODRIVER_VERSION environment-variable handling shown in the issue. Compare the declared variable name with the name read from process.env, then verify that an override is used during installation on the supported platforms. Done means the documented environment variable consistently controls the geckodriver version.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.