sitespeedio / sitespeedio/browsertime
Firefox PerfStats feature mask needs to be updated to support 64bit mask
Open
Nobody has claimed this yet.
bug
- Dominant language
- JavaScript
- Stars
- 652
- Forks
- 141
- Avg merge
- 3h 56m
- Merged PRs (30d)
- 5
Description
Have you read the documentation?
- Yes, I've read the how to make a reproducable bug guide
- Yes, I've read the how to debug my script guide
URL
What are you trying to accomplish
We currently initialize the Firefox PerfStats (internal timing metrics) with a 32-bit feature mask, 0xFF_FF_FF_FF meaning collect all metrics.
However, Firefox has since upgraded to a 64-bit feature mask, so we want to pass in
0xFFFF_FFFF_FFFF_FFFF to collect all metrics.
What browser did you use?
Firefox
How to reproduce
Collect PerfStats and observe that the last ones are all zero.
Log output
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at lib/core/engine/command/perfStats.js around line 29, where Firefox PerfStats is initialized with the feature mask. Reproduce collection for Firefox and verify that updating the mask to the 64-bit value causes the previously zero-valued final metrics to be collected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- performance
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100