sitespeedio / sitespeedio/browsertime
Windows Firefox videos become corrupted when I use `--videoParams.convert false --videoParams.addTimer false`
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 652
- Forks
- 141
- Avg merge
- 3h 56m
- Merged PRs (30d)
- 5
Description
Have you read the documentation?
- Yes, I've read the how to make a reproducable bug guide
- Yes, I've read the how to debug my script guide
URL
What are you trying to accomplish
I was trying to run browsertime with these two flags --videoParams.convert false --videoParams.addTimer false as the additional processing these flags cause add about 30 seconds per iteration (it ends up taking up to 15 mins of a 50min task). This works on all platforms except windows where the videos become corrupted. I'm thinking there might be something in one of those two post-processing steps that makes the videos viable for windows.
What browser did you use?
Firefox
How to reproduce
Run Browsertime on Firefox on Windows with at least the following flags: --videoParams.convert false --videoParams.addTimer false --video true --visualMetrics true --visualMetricsContentful true --visualMetricsPerceptual true --visualMetricsPortable true --videoParams.keepOriginalVideo true --firefox.windowRecorder false
Full set of flags used: browsertime.js browsertime_pageload.js --firefox.noDefaultPrefs --browsertime.page_cycle_delay 1000 --skipHar --pageLoadStrategy none --webdriverPageload true --firefox.disableBrowsertimeExtension true --pageCompleteCheckStartWait 5000 --pageCompleteCheckPollTimeout 1000 --timeouts.pageLoad 60000 --timeouts.script 60000 --browsertime.page_cycles 1 --pageCompleteWaitTime 5000 --browsertime.url https://www.amazon.com/s?k=laptop&ref=nb_sb_noss_1 --browsertime.post_startup_delay 1 --iterations 1 --videoParams.androidVideoWaitTime 20000 --browsertime.chimera false --browsertime.test_bytecode_cache false --firefox.perfStats false --browsertime.secondary_url https://www.amazon.com/Acer-A515-46-R14K-Quad-Core-Processor-Backlit/dp/B08VKNVDDR/ref=sr_1_3?dchild=1&keywords=laptop&qid=1627047187&sr=8-3 --browsertime.commands --viewPort 1280x1024 --browser firefox --video true --visualMetrics true --visualMetricsContentful true --visualMetricsPerceptual true --visualMetricsPortable true --videoParams.keepOriginalVideo true --firefox.windowRecorder false --xvfbParams.display 0 --browsertime.testName amazon --browsertime.liveSite False --browsertime.loginRequired False
Relevant log output
No relevant logs available.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue with Browsertime on Firefox for Windows using --videoParams.convert false, --videoParams.addTimer false, --video true, and --videoParams.keepOriginalVideo true. Compare the resulting videos with runs on other platforms and with post-processing enabled; done means the Windows videos remain playable without the extra processing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- cli, performance, tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100