sitespeedio / sitespeedio/browsertime

Running with --video where the video would need to be overwritten silently stalls browsertime (macOS)

Open
#1,566 5 comments 0 reactions 1 assignee View on GitHub

@soulgalore is already working on this.

Since May 5, 2021.

Dominant language
JavaScript
Stars
652
Forks
141
Avg merge
3h 56m
Merged PRs (30d)
5

Description

When running a test where the video recording already exists (and would need to be overwritten), I'm seeing browsertime silently stall after issuing the ffmpeg video command. (macOS).

If I delete the previously-made video, the new recording will be made and the test will proceed.

For instance, here's an example ffmpeg command:

[2021-04-30 16:25:37] DEBUG: [browsertime.video] Start FFMPEG with ["-f","avfoundation","-i","2","-r",30,"-filter:v","crop=2732:1536:0:0","-codec:v","libx264rgb","-threads",0,"-crf","0","-preset","ultrafast","/Users/acreskey/tools/browsertime/responsiveness/browsertime-results/facebook/firefox/x11-tmp.mp4"]

If I run that from the terminal, I see the prompt: Overwrite ? [y/N]

It looks like adding the ffmpeg option, -y will force an overwrite.
@dpalmeiro, who helped me debug this, raised the possibility that a timeout could be added.

Here's my browsertime command:

./browsertime/bin/browsertime.js --skipHar --videoParams.addTimer false --videoParams.createFilmstrip false --videoParams.framerate 60 --video true --visualMetrics true  --firefox.windowRecorder false --visualMetricsContentful -n 1  --verbose --resultDir  browsertime-results/facebook/firefox -b firefox tests/facebook.js

Where the test is simply:

module.exports = async function(context, commands) {
return commands.measure.start('https://www.facebook.com/');
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.