sitespeedio / sitespeedio/browsertime

Inconsistent replacing of characters in path names

Open
#1,487 3 comments 0 reactions 1 assignee View on GitHub

@soulgalore is already working on this.

Since Feb 9, 2021.

bug help wanted
Dominant language
JavaScript
Stars
652
Forks
141
Avg merge
3h 56m
Merged PRs (30d)
5

Description

Starting with sitespeed.io:16.0.2, some characters (at least the colon) in path names are in some places replaced to a "-", in other places not replaced at all.

To reproduce the issue create an urls.txt file with a ":" in the alias part:

$ cat /tmp/sitespeed/urls.txt 
https://www.sitespeed.io foo:bar

$ docker run --name=sitespeed_mobile --privileged --shm-size=1g --rm -v /tmp/sitespeed:/sitespeed.io sitespeedio/sitespeed.io:16.8.0 --browsertime.iterations 1 -b chrome ./urls.txt
...
[2021-02-08 13:59:50] INFO: Could not read filmstrip dir Error: ENOENT: no such file or directory, scandir '/sitespeed.io/sitespeed-result/www.sitespeed.io/2021-02-08-13-59-34/pages/www_sitespeed_io/foo-bar/data/filmstrip/1''
[2021-02-08 13:59:52] INFO: Could not read filmstrip dir Error: ENOENT: no such file or directory, scandir '/sitespeed.io/sitespeed-result/www.sitespeed.io/2021-02-08-13-59-34/pages/www_sitespeed_io/foo-bar/data/filmstrip/1''
...

Looking at the result pages, it's not possible to access the screenshot image or video.

The file tree also shows the inconsistent replacing:

$ cd /tmp/sitespeed/sitespeed-result/www.sitespeed.io/2021-02-08-13-59-34
$ find pages/www_sitespeed_io/
pages/www_sitespeed_io/
pages/www_sitespeed_io/foo:bar
pages/www_sitespeed_io/foo:bar/data
pages/www_sitespeed_io/foo:bar/data/video
pages/www_sitespeed_io/foo:bar/data/video/1.mp4
pages/www_sitespeed_io/foo:bar/data/video/images
pages/www_sitespeed_io/foo:bar/data/video/images/1
pages/www_sitespeed_io/foo:bar/data/screenshots
pages/www_sitespeed_io/foo:bar/data/screenshots/1
pages/www_sitespeed_io/foo:bar/data/screenshots/1/afterPageCompleteCheck.png
pages/www_sitespeed_io/foo:bar/data/filmstrip
pages/www_sitespeed_io/foo:bar/data/filmstrip/1
pages/www_sitespeed_io/foo:bar/data/filmstrip/1/ms_000733.png
pages/www_sitespeed_io/foo:bar/data/filmstrip/1/ms_000000.png
pages/www_sitespeed_io/foo:bar/data/filmstrip/1/ms_000666.png
pages/www_sitespeed_io/foo-bar
pages/www_sitespeed_io/foo-bar/data
pages/www_sitespeed_io/foo-bar/data/browsertime.har
pages/www_sitespeed_io/foo-bar/1.html
pages/www_sitespeed_io/foo-bar/index.html

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.