sitespeedio / sitespeedio/browsertime
Do not add use metrics if the main page gives an HTTP error
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- JavaScript
- Stars
- 652
- Forks
- 141
- Avg merge
- 3h 56m
- Merged PRs (30d)
- 5
Description
We should make it configurable to include metrics from pages that gives errors. By default if the main page gives a > 399 error we should exclude those metrics from the statistics, see See https://github.com/sitespeedio/sitespeed.io/issues/3127
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the linked sitespeed.io issue 3127, then locate the code that gathers metrics and builds statistics for the main page. Done means the behavior is configurable, excludes metrics by default when the main page returns an HTTP status above 399, and includes them when enabled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- performance, web-dev
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100