sip-protocol / sip-protocol/sipher

[tech-debt] Narrow DashboardView unauthed tagline gating from `status !== 'authed'` to `status === 'unauthed'`

Open
#245 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

priority:low tech-debt
Dominant language
TypeScript
Stars
1
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Follow-up from Wave 2a Cluster E1 (#221 About SIPHER tagline). Code-quality reviewer flagged the broad gating.

Current behavior

app/src/views/DashboardView.tsx:159 gates the unauthed tagline on status !== 'authed':

```tsx
{status !== 'authed' && (

Multi-chain privacy command center for shielded transfers across 9+ chains.

)} \`\`\`

This matches the spec text verbatim and is documented by an explicit test (DashboardView.test.tsx:175-183). But it also shows the tagline for:

  • status === 'connecting' — transient flash of marketing copy while auth resolves
  • status === 'expired' — returning user who knows what SIPHER is, the marketing pitch is wasted real-estate
  • status === 'error' — auth error state, user probably doesn't want marketing copy mid-error

Proposed change

Narrow gating to status === 'unauthed' || status === 'error', OR just status === 'unauthed'.

Trade-off: brief tagline flash during initial auth connecting would disappear, slight UX improvement. Existing test at DashboardView.test.tsx:175-183 documents the current behavior — needs updating to assert the narrowed gating.

Decision needed

RECTOR call: accept current "fallback to pitch" UX, or narrow to unauthed only?

Source

Wave 2a Cluster E1 code-quality review minor finding #3.

Priority

Low — UX polish, not a regression.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read app/src/views/DashboardView.tsx around line 159 and DashboardView.test.tsx around lines 175-183, then resolve the stated RECTOr decision about which auth states should show the tagline. Update the view and its explicit test to match the chosen gating, and run the DashboardView test to confirm all relevant states behave as intended.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.