sinon not throwing the error that been thrown when the error is undefined and also fail to assert
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 9.8k
- Forks
- 808
- PR merge metrics
- No merged PRs in 30d
Description
Describe the bug
If the function throw undefined then:
- calling the function does not throw
sinon.assert.threw(a);fail
To Reproduce
ReplIt Link
const a = sinon.spy(() => {
throw undefined;
});
try {
a();
} catch (e) {
// 1. this won't be logged
console.log('Error has being thrown');
}
// 2. This will throw
// Uncaught AssertError: spy did not throw exception
sinon.assert.threw(a);
Expected behavior
- throw the thrown error
- the assertion should pass
As said in the docs about the 2nd thing:
sinon.assert.threw(spyOrSpyCall, exception);Passes if spy threw the given exception.
The exception can be a String denoting its type, or an actual object.
If only one argument is provided, the assertion passes if spy ever threw any exception.
Context (please complete the following information):
- Library version: 14.0.0
- Environment: node
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the JavaScript reproduction in the linked Replit example and trace how the spy records a thrown undefined value and how sinon.assert.threw checks it. Confirm both expected behaviors: the original call propagates the thrown value and the assertion passes when any exception was thrown.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100