sinonjs / sinonjs/sinon

Name differences

Open
#1,509 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Difficulty: Medium hacktoberfest Help wanted pinned
Dominant language
JavaScript
Stars
9.8k
Forks
809
PR merge metrics
No merged PRs in 30d

Description

It might be logical reasons that I don't know about, but I wonder about some of the name differences between sinon-methods:

spy.notCalledWith
assert.neverCalledWith

Should they have the same name?

stub.callsFake
stub.callsArg
stub.callsArgWith
stub.callThrough
stub.callArg
stub.callArgWith

I often end up checking the docs where there is 'calls*' and where there is 'call*'.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the documentation entries for spy.notCalledWith, assert.neverCalledWith, and the listed stub call methods. Compare their naming conventions and the surrounding API guidance; this issue is done only when a specific naming decision and its affected documentation or implementation scope are agreed.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
testing
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.