sindresorhus / sindresorhus/query-string

Lack of symmetry between parse and stringify

Open
#295 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement help wanted
Dominant language
JavaScript
Stars
6.9k
Forks
455
PR merge metrics
No merged PRs in 30d

Description

stringify(parse('?%20&')) yields only &.

Bit of an edge-case I admit, but do we want to be losing this information?

parse('?%20&') yields {"":null," ":null}.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the reported behavior through the parse and stringify entry points with '?%20'. Inspect how each function handles the empty key and space-only component, then determine the expected round-trip behavior; done means the chosen behavior is covered by a regression test.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.