sindresorhus / sindresorhus/Defaults
Cache bridge deserialization
Open
Nobody has claimed this yet.
enhancement
help wanted
- Dominant language
- Swift
- Stars
- 2.5k
- Forks
- 163
- PR merge metrics
- No merged PRs in 30d
Description
struct User3: Codable, Defaults.Serializable {
let name: String
let age: String
}
extension Defaults.Keys {
static let user3 = Key<User3>("user3", default: .init(name: "Hello", age: "24"))
}
...
func test2() {
print(Defaults[.user3])
print(Defaults[.user3])
}
...
The above code will call bridge.deserialize twice. If user3 is an array and there are many attributes of the User3 type, will it affect performance?
Would it be better to cache the data after Defaults[.user3] is executed once?
extension Defaults.Serializable {
....
static func toValue(_ anyObject: Any) -> Self? {
// Return directly if `anyObject` can cast to Value, since it means `Value` is a natively supported type.
if
isNativelySupportedType,
let anyObject = anyObject as? Self
{
return anyObject
} else if let value = bridge.deserialize(anyObject as? Serializable) {
return value as? Self
}
return nil
}
....
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in Utilities.swift at Defaults.Serializable.toValue(_:), then trace the bridge.deserialize call used by the test2 example. Determine whether repeated Defaults[.user3] access deserializes the value each time and define the expected behavior for caching without changing the existing Serializable conversion semantics.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- database
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100