simra-project / simra-project/simra-android

Rohdistanzen landen im Binary

Open
#40 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
22
Forks
16
PR merge metrics
No merged PRs in 30d

Description

Die Rohdistanzen landen im Binary, aber ohne Lenkerbreiten-Korrektur. Und dieses obsLiteSessionXY.bin wird dann ins portal geladen. Stimmt das?

if (obsEvent.hasDistanceMeasurement()) {
    val dm = obsEvent.distanceMeasurement
    obsEvent = obsEvent.toBuilder()
        .addTime(obsTime)
        .addTime(smartphoneTime)
        .setDistanceMeasurement(dm)
        .build()
    // left sensor event
    if (obsEvent.distanceMeasurement.sourceId == 1) {
        val distance = (
            (obsEvent.distanceMeasurement.distance * 100)
            + SharedPref.Settings.Ride.OvertakeWidth.getHandlebarWidthLeft(context)
        ).toInt()
        // calculate minimal moving median for when the user presses obs lite button
        movingMedian.newValue(distance)
    }
}
  • val dm = obsEvent.distanceMeasurement → dm ist der Rohwert vom OBS-Lite-Board (Sensor → Objekt, in m).
  • setDistanceMeasurement(dm) → genau dieses dm wird wieder in obsEvent gesetzt, ohne Veränderung von dm.distance.
  • Die Rechnung mit Lenkerbreite passiert nur in der lokalen Variable distance (in cm) für movingMedian – dm bleibt unangetastet

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the shown obsEvent distanceMeasurement handling and trace how obsEvent is serialized into obsLiteSessionXY.bin and loaded into the portal. Confirm whether the binary contains the raw sensor distance or the handlebar-width-adjusted value, then document or correct the behavior so the stored value matches the intended measurement.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.