simplesamlphp / simplesamlphp/xml-soap
Re-enable unit test
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 0
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Description
Part of the test in tests/SOAP11/Type/EncodingStyleValueTest.php is commented because of a bug in the PCRE-library.
See: https://github.com/php/php-src/issues/22361
This issue is a reminder to re-enable the test as soon as the fixed 10.48 version of the PCRE-library becomes available in the ubuntu-latest runner.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in tests/SOAP11/Type/EncodingStyleValueTest.php and inspect the commented test portion and the PCRE version available in the ubuntu-latest runner. Once PCRE 10.48 is available, re-enable the test and run the relevant test file; done means the test runs successfully without the PCRE-related failure.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- ci-cd, testing
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 72/100