simplesamlphp / simplesamlphp/xml-common
Re-enable unit test
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 4
- Forks
- 9
- PR merge metrics
- No merged PRs in 30d
Description
Part of the test in tests/XML/Assert/StringTest.php is commented because of a bug in the PCRE-library.
See: https://github.com/php/php-src/issues/22361
This issue is a reminder to re-enable the test as soon as the fixed 10.48 version of the PCRE-library becomes available in the ubuntu-latest runner.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open tests/XML/Assert/StringTest.php and inspect the commented test. Check whether the ubuntu-latest runner provides the fixed PCRE 10.48 version, then run the relevant test file. The work is done when the test is re-enabled and passes with that dependency version.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 75/100