simplesamlphp / simplesamlphp/simplesamlphp
adfs: enabling module breaks admin/federation page
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 1.1k
- Forks
- 704
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 4
Description
Help us to keep this issue-tracker clean! For questions or support, please refer to our mailing lists
Specifics of your environment
- IdP/SP/Proxy? IdP
- SimpleSAMLphp: 2.4.1
- PHP: What version are you using? 8.4.7
- Platform: unix or Windows? Unix
- Webserver: Apache/Nginx/ISS? Apache
Describe the bug
When accessing module.php/admin/federation an exception is thrown when the adfs-module is installed.
To Reproduce
Steps to reproduce the behavior:
- Install the latest version of the adfs-moduleGo to '...'
- module.php/admin/federation
- See error
Expected behavior
No exception
Screenshots or logs
Backtrace:
2 src/SimpleSAML/Error/ExceptionHandler.php:39 (SimpleSAML\Error\ExceptionHandler::customExceptionHandler)
1 vendor/symfony/error-handler/ErrorHandler.php:538 (Symfony\Component\ErrorHandler\ErrorHandler::handleException)
0 [builtin] (N/A)
Caused by: Symfony\Component\ErrorHandler\Error\UndefinedMethodError: Attempted to call an undefined method named "getHostedMetadata" of class "SimpleSAML\Module\adfs\IdP\ADFS".
Backtrace:
6 modules/admin/src/Controller/Federation.php:273 (SimpleSAML\Module\admin\Controller\Federation::getHostedIdP)
5 modules/admin/src/Controller/Federation.php:131 (SimpleSAML\Module\admin\Controller\Federation::main)
4 vendor/symfony/http-kernel/HttpKernel.php:181 (Symfony\Component\HttpKernel\HttpKernel::handleRaw)
3 vendor/symfony/http-kernel/HttpKernel.php:76 (Symfony\Component\HttpKernel\HttpKernel::handle)
2 vendor/symfony/http-kernel/Kernel.php:197 (Symfony\Component\HttpKernel\Kernel::handle)
1 src/SimpleSAML/Module.php:234 (SimpleSAML\Module::process)
0 public/module.php:17 (N/A)
Additional context
The solution is probably to implement the missing method in the adfs-module. If analysis supports this, this issue should be moved to the proper repository.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at modules/admin/src/Controller/Federation.php:273, where getHostedIdP calls the missing getHostedMetadata method on the ADFS class. Inspect the installed adfs-module implementation and its metadata handling, then reproduce module.php/admin/federation with the reported environment; done means the page loads without the undefined-method exception.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- authentication
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100