simplesamlphp / simplesamlphp/simplesamlphp-module-oidc

Token endpoint requirement for `client_id` parameter

Open
#306 1 comment 0 reactions 1 assignee View on GitHub

@cicnavi is already working on this.

Since Apr 30, 2025.

prepared
Dominant language
PHP
Stars
50
Forks
28
Avg merge
1m
Merged PRs (30d)
2

Description

Currently we require that client_id parameter is always present for requests on token endpoint. However, OAuth2 says:

client_id
REQUIRED, if the client is not authenticating with the
authorization server as described in Section 3.2.1.

This needs to be brought in line with the fact that, for example, we support private_key_jwt client authentication.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.