simplesamlphp / simplesamlphp/simplesamlphp-module-metarefresh

Metarefresh module should add requested attribute values to PHP metadata when adding requested attributes

Open
#51 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
9
Forks
19
PR merge metrics
No merged PRs in 30d

Description

Is your feature request related to a problem? Please describe.

XML metadata supports not only specifiying an SP's requested attributes, but also specific values of those attributes:

    <RequestedAttribute FriendlyName="eduPersonEntitlement" Name="urn:oid:1.3.6.1.4.1.5923.1.1.1.7" NameFormat="urn:oasis:names:tc:SAML:2.0:attrname-format:uri" isRequired="true">                                                         
      <saml:AttributeValue xmlns:saml="urn:oasis:names:tc:SAML:2.0:assertion">urn:mace:incommon:uiuc.edu:some:value</saml:AttributeValue>                                                                                                    
    </RequestedAttribute>

Currently, the metarefresh module includes the requested attributes in the generated PHP metadata, but not the requested values:

'attributes' => [
    'urn:oid:1.3.6.1.4.1.5923.1.1.1.7',
]

It should generate this instead:

'attributes' => [
    'urn:oid:1.3.6.1.4.1.5923.1.1.1.7' => [ ' urn:mace:incommon:uiuc.edu:some:value'
]

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the metarefresh module's RequestedAttribute parsing and PHP metadata generation entry points, using the XML example and expected PHP structure in the issue as the guide. Confirm that requested attribute values are retained and represented under their attribute names, then verify the generated metadata matches the requested shape.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
authentication
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.