simplesamlphp / simplesamlphp/simplesamlphp-module-metarefresh
writeMetadataPdo surplus configuration
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 9
- Forks
- 19
- PR merge metrics
- No merged PRs in 30d
Description
There's a Too many arguments to function __construct(). 2 provided, but 1 accepted. warning being picked up in MetaLoader.php:675
The constructor on Metadata\MetaDataStorageHandlerPdo accepts one config parameter but then doesn't do anything with it anyway, calling Database::getInstance(); instead.
My inclination was to drop passing the config in the metarefresh module entirely but not sure if that's the right approach.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at MetaLoader.php:675 and inspect the construction of Metadata\MetaDataStorageHandlerPdo, then compare it with that class's constructor and its use of Database::getInstance(). Determine whether the surplus configuration should be removed or handled consistently, and verify that the constructor warning no longer appears.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- database
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100