simplesamlphp / simplesamlphp/simplesamlphp-module-ldap
Have ldap:AttributeAddUsersGroups support ldap:LdapMulti
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 5
- Forks
- 14
- PR merge metrics
- No merged PRs in 30d
Description
Hi, I noted that in the docs for ldap:AttributeAddUsersGroups, it is clearly stated:
Note: ldap:LdapMulti is not supported as the SimpleSAMLphp framework does not pass any information about which LDAP source the user selected.
And I understand that if you do have multiple LDAP instances, you can place your ldap:AttributeAddUsersGroups configuration in the service provider metadata and in that way control which LDAP instance is queried for groups when a user attempts to access a particular service.
But I do wonder if there is any appetite for adding support for ldap:LdapMulti? So that with ldap:AttributeAddUsersGroups configuration in the IdP metadata, groups will be queried from the authentication source (organisation) the user selected?
I'd be very happy to work on this if anyone feels it would be a useful feature to add.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with docs/ldap.md and the ldap:AttributeAddUsersGroups section to understand the documented limitation. Then trace how IdP metadata and the selected authentication source are represented, since the issue identifies missing framework information but no implementation entry point or test. Done would require an agreed design, support for ldap:LdapMulti, and updated documentation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- authentication
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100