simplesamlphp / simplesamlphp/simplesamlphp-module-ldap
ActiveDirectory connector custom error messages
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 5
- Forks
- 14
- PR merge metrics
- No merged PRs in 30d
Description
The 'resolveBindException' function in the Active Directory function never gets called when a password is expired. I made a test change by renaming it 'resolveBindError' (taken from standard LDAP connector class) and changing the signature, and now the code gets called but the error messages aren't defined which cause an error when a password is expired:
SimpleSAML\Error\Exception: Key "RESETPASSWORD" for sequence/mapping with keys "ACSPARAMS...." does not exist in core:loginuserpass.twig
I have tried defining custom errors using the getCustomTitles() and getCustomDescriptions() methods but I'm not doing it right, but now I'm wondering if I'm going down the correct path. Any suggestions?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the Active Directory connector's resolveBindException function with the standard LDAP connector's resolveBindError behavior, including the getCustomTitles() and getCustomDescriptions() methods. Trace how expired-password errors reach core:loginuserpass.twig and verify that the resulting error keys and messages are defined so the missing RESETPASSWORD key no longer causes an exception.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- authentication
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100