simplesamlphp / simplesamlphp/simplesamlphp-module-aggregator2
Fix local (non-http) metadata-locations
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 5
- Forks
- 6
- PR merge metrics
- No merged PRs in 30d
Description
- SimpleSAML\Test\Module\aggregator\Controller\AggregatorTest::testGetWithId
Symfony\Component\HttpClient\Exception\InvalidArgumentException: Invalid URL: scheme is missing in "tests/metadata/example.xml". Did you forget to add "http(s)://"?
/home/runner/work/simplesamlphp-module-aggregator2/simplesamlphp-module-aggregator2/vendor/symfony/http-client/HttpClientTrait.php:582
/home/runner/work/simplesamlphp-module-aggregator2/simplesamlphp-module-aggregator2/vendor/symfony/http-client/HttpClientTrait.php:179
/home/runner/work/simplesamlphp-module-aggregator2/simplesamlphp-module-aggregator2/vendor/symfony/http-client/CurlHttpClient.php:91
/home/runner/work/simplesamlphp-module-aggregator2/simplesamlphp-module-aggregator2/vendor/simplesamlphp/simplesamlphp/src/SimpleSAML/Utils/HTTP.php:554
/home/runner/work/simplesamlphp-module-aggregator2/simplesamlphp-module-aggregator2/src/EntitySource.php:150
/home/runner/work/simplesamlphp-module-aggregator2/simplesamlphp-module-aggregator2/src/EntitySource.php:228
/home/runner/work/simplesamlphp-module-aggregator2/simplesamlphp-module-aggregator2/src/EntitySource.php:263
/home/runner/work/simplesamlphp-module-aggregator2/simplesamlphp-module-aggregator2/src/Aggregator.php:514
/home/runner/work/simplesamlphp-module-aggregator2/simplesamlphp-module-aggregator2/src/Aggregator.php:693
/home/runner/work/simplesamlphp-module-aggregator2/simplesamlphp-module-aggregator2/src/Aggregator.php:727
/home/runner/work/simplesamlphp-module-aggregator2/simplesamlphp-module-aggregator2/src/Controller/Aggregator.php:98
/home/runner/work/simplesamlphp-module-aggregator2/simplesamlphp-module-aggregator2/tests/src/Controller/AggregatorTest.php:125
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with tests/src/Controller/AggregatorTest.php and reproduce testGetWithId, then trace the local metadata path through src/EntitySource.php as shown in the failure. The change is done when tests/metadata/example.xml is accepted as a local metadata location without Symfony reporting a missing URL scheme, and the test passes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php, symfony
- Domain
- backend, testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 72/100