simplesamlphp / simplesamlphp/simplesamlphp-assets-base

Theme colour overrides

Open
#104 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
No language data
Stars
0
Forks
2
Avg merge
8m
Merged PRs (30d)
3

Description

The #db0100 colour is hard-coded in several places in the SCSS, making it quite difficult for theme developers to override.

Doing something like:

:root {
  --simplesamlphp-color: #db0100;
}

and then referencing it elsewhere as e.g.:

.pure-button-red {
  background-color: var(--simplesamlphp-color);
  color: #fff;
}

would make it much easier to override the colour consistently by simply declaring an additional <style> element in _head.twig with the new --simplesamlphp-color variable definition. The same could be done with the other colours that are used.

I'd do this as a pull request, but I think this repo has complexity I do not understand :-)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the SCSS assets for the hard-coded #db0100 value and inspect _head.twig, which is the proposed place for theme overrides. Replace the repeated colour usage with consistently overridable variables, including the other colours where appropriate. Done means a style declaration in _head.twig can change the theme colour throughout the affected assets.

Written by the indexing model from the issue text.

Assessment

Tech stack
scss
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.