simplesamlphp / simplesamlphp/saml2

Not compliant with specs for encrypted elements

Open
#360 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
306
Forks
138
PR merge metrics
No merged PRs in 30d

Description

This needs fixing

<xenc:EncryptedKey> [Zero or More]

Wrapped decryption keys, as defined by [XMLEnc]. Each wrapped key SHOULD include a
Recipient attribute that specifies the entity for whom the key has been encrypted. The value of
the Recipient attribute SHOULD be the URI identifier of a SAML system entity, as defined by
Section 8.3.6

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the handling of xenc:EncryptedKey elements and compare it with the encrypted-element requirements quoted in the issue and the referenced XMLEnc and SAML specifications. Done means the implementation complies with the stated cardinality and Recipient guidance, with coverage for the corrected behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.